Support disabling compile time http request #15
Merged
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new configuration flag, `:fetch_latest`, which entirely disables the HTTP request at compile-time that tries to get the latest `public_suffix_list.dat`. This behavior was (sort of) achievable without this flag, by configuring the `:public_suffix_list_url` to the empty charlist, but doing so produced a warning on each compile. With the new flag, there's no error. This is desirable for our use-case for a couple reasons: 1. We want the development build to match as closely as possible what we'll deploy in prod 2. We don't want the possibility of failing production builds based on the availability of a third-party web host
|
Hi, thanks so much for your excellent PR! I'll cut a new release today. |
|
Sweet, thank you so much! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks so much for your work on this library—it's saved us a ton of time on our project.☺️
This PR adds a new configuration flag,
:fetch_latest, which entirely disables the HTTP request at compile-time that fetches the latestpublic_suffix_list.dat. This behavior was (sort of) achievable without this flag, by configuring the:public_suffix_list_urlto the empty charlist, but doing so produced a warning on each compile. With the new flag, there's no error.This is desirable for our use-case for a couple reasons:
Resolves #4